Allow compiling microsoft-ui-uiAutomation with VS 2022#14326
Merged
Conversation
…e platform toolset as the rest of nvdaHelper. Allowing this project to be compiled with VS 2022.
… longer necessary.
seanbudd
approved these changes
Nov 3, 2022
Co-authored-by: Sean Budd <sean@nvaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Taken from pr #14313 which cannot yet be merged in its entireity.
Summary of the issue:
NVDA can be compiled locally with VS 2022, but the VS 2019 build tools are required, due to the Microsoft-UI-UIAutomation project specifying the VS 2019 platform toolset by default.
Description of user facing changes
None
Description of developer facing changes
NVDA can now be fully compiled locally with Visual Studio 2022, without also requiring the 2019 build tools.
Description of development approach
Testing strategy:
Built with VS 2022 with no VS 2019 components installed.
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: