Add support for embedded WPFTermControl in LTS Visual Studio by codeofdusk · Pull Request #14194 · nvaccess/nvda

codeofdusk · 2022-09-29T00:40:26Z

Link to issue number:

None.

Summary of the issue:

Visual Studio uses a WPF implementation of the Windows Terminal control that will use a different UIA class name. As such, NVDA currently does not add the needed overlay class to this control, so autoread and password suppression do not work as expected.

Description of how this pull request fixes the issue:

Added the new UIA class name to the necessary lists.

Testing strategy:

N/A

Known issues with pull request:

Given that this is a small, targetted bug fix, please merge to 2022.4.

Change log entries:

=== Bug Fixes ===

Text reporting, Braille output, and password suppression now work as expected in the embedded Windows Terminal control in Visual Studio 2022.

Code Review Checklist:

Pull Request description:
- description is up to date
- change log entries
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
API is compatible with existing add-ons.
Documentation:
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
Security precautions taken.

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

seanbudd · 2022-09-29T02:35:23Z

Once this PR is ready/approved, can you:

Update the changes file yourself, as 2022.4 is frozen, merge conflicts are unlikely
Temporarily re-target the final PR against master, so that a branch build occurs
Re-target the PR to branchFor2022.4 after a successful build

seanbudd · 2022-09-29T03:15:04Z

It appears that include/sonic has been mistakenly reverted to an earlier commit in this PR

codeofdusk · 2022-09-29T03:16:05Z

I think just a result of the branch change on GitHub. Should I rebase on master too?

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

seanbudd · 2022-09-29T03:20:23Z

I think just a result of the branch change on GitHub.

I don't think it is, it was changed in this commit: 1d3b781

Should I rebase on master too?

No, we want this PR to retarget the branch for 2022.4 still

…into add-wpf-terminal

seanbudd · 2022-09-29T03:38:38Z


-		# Support Windows Console's UIA interface
+		# Support Windows Console and Terminal
+		_all_wt_UIAClassNames = frozenset((


I think typical syntax for this is the following, but I don't think it matters

Suggested change

_all_wt_UIAClassNames = frozenset((

_all_wt_UIAClassNames = frozenset({

Add support for new WPFTermControl class.

8e89354

codeofdusk requested a review from a team as a code owner September 29, 2022 00:40

codeofdusk requested review from seanbudd and removed request for a team September 29, 2022 00:40