Skip to content

Update sonic to commit 1d70513#14180

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
codeofdusk:update-sonic-2023.1
Sep 26, 2022
Merged

Update sonic to commit 1d70513#14180
seanbudd merged 3 commits into
nvaccess:masterfrom
codeofdusk:update-sonic-2023.1

Conversation

@codeofdusk

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

The Sonic library used to speed up eSpeak is many years out of date.

Description of how this pull request fixes the issue:

Updates to latest commit.

Testing strategy:

Verified that rate boost is still functional. Merge early to catch issues before release.

Known issues with pull request:

None known.

Change log entries:

== Changes ==

  • Updated Sonic rate boost library to commit 1d70513.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner September 22, 2022 23:05
@codeofdusk codeofdusk requested a review from seanbudd September 22, 2022 23:05

@lukaszgo1 lukaszgo1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version of Sonic in the readme.

@seanbudd seanbudd marked this pull request as draft September 26, 2022 00:24
@codeofdusk codeofdusk marked this pull request as ready for review September 26, 2022 05:54
@seanbudd seanbudd merged commit cfdc5cb into nvaccess:master Sep 26, 2022
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants