Skip to content

Line indent - Wrong option selected when switching profile #14170

@CyrilleB79

Description

@CyrilleB79

Steps to reproduce:

  1. Create a profile for Notepad
  2. While in Notepad, open document settings and set ""Line indentation reporting" on "Tones", then validate.
  3. Alt+Tab to Firefox
  4. Open document settings and set "Line indentation reporting" on "Speech", then validate.
  5. Alt+tab to Notepad.
  6. Open document settings window and look at "Line indentation reporting" value.

Actual behavior:

"Line indentation reporting" is set on "Both Speech and Tones"

Expected behavior:

"Line indentation reporting" is set on "Tones" as it has been set at step 2 and not modified afterwards.

NVDA logs, crash dumps and other attachments:

nvda_combinedOptions.log

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2022.3beta5

Windows version:

Windows 10 2004 (x64) build 19041.388

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Already present in 2022.2.
And probably much earlier versions also.

If NVDA add-ons are disabled, is your problem still occurring?

Yes, tested with no add-on.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Not tested but unrelated.

Cause of the issue

In the GUI, the "Line indentation reporting" is one combobox, but its value is stored thanks to two separate values in the config (one for speech and the other for tones).

Solutions

To solve this issue, the easiest way is to have GUI controls match the config, i.e. one control matches one and only one config item. Thus there are two options:

  1. Upgrade the config to store the required in a single item of type int or string, not boolean.
  2. Or modify the GUI to replace the combobox with two checkboxes, one for speech and one for tones; the script controlling this option should then also be split into two separate scripts.

I prefer solution 1., which allow to keep less items in the GUI, especially in the doc formatting settings panel; this also prevent from increasing the number of tabs when navigating in this panel.

NVAccess,
could you please indicate if you agree with solution 1?
Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature/configuration-profilesp3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions