Skip to content

Fix "Restore defaults" button action In advanced settings panel#14149

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:restoreAdvSettings
Sep 15, 2022
Merged

Fix "Restore defaults" button action In advanced settings panel#14149
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:restoreAdvSettings

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None.
Fix-up of #12689.

Summary of the issue:

When pressing "Restore defaults" button in advanced settings panel, the option "Play a sound for logged errors" is not restored.

Description of user facing changes

Pressing "Restore defaults" in adv settings panel now restores all the options of this panel.

Description of development approach

  • Added self.playErrorSoundCombo in restoreToDefaults and haveConfigDefaultsBeenRestored functions where it was missing.
  • Also reordered the statements in these two functions to match the advanced settings panel layout (tab order) so that checking all the items be more easy.

Testing strategy:

Manual testing: Checked that the value is correctly restored.

Known issues with pull request:

None

Change log entries:

Bug fixes
In advanced settings, "Play a sound for logged errors" option is now correctly restored to its default value when pressing the "Restore defaults" button.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

…correctly restored to its default value when pressing the "Restore defaults" button.
@CyrilleB79 CyrilleB79 marked this pull request as ready for review September 14, 2022 19:51
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner September 14, 2022 19:51
@CyrilleB79 CyrilleB79 requested a review from seanbudd September 14, 2022 19:51
@seanbudd seanbudd merged commit 8643be1 into nvaccess:master Sep 15, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Sep 15, 2022
@CyrilleB79 CyrilleB79 deleted the restoreAdvSettings branch September 15, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants