Initialize MathPlayer when NVDA starts#13486
Merged
Merged
Conversation
michaelDCurran
previously approved these changes
Mar 16, 2022
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
Looks good. I confirmed NVDA's MathPlayer support still functions after this change. E.g. I was able to read and interact with math in MS Word.
michaelDCurran
approved these changes
Mar 16, 2022
LeonarddeR
approved these changes
Mar 16, 2022
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Just a thought, should mathPres also be terminateable as well as be terminated/initialized in core.resetConfiguration?
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13463
Summary of the issue:
mathPres.ensureInitis called whenever math content is expected to be read, including from getTextWithFields.This is called with every read when using UIA with Word.
If mathPlayer is not installed, this pollutes the log.
Ideally, math should be initialized at NVDA startup time.
Description of how this pull request fixes the issue:
Makes mathPlayer initialize on start up.
Removes
mathPlayer.ensureInitusages from within NVDA.External documentation referencing mathPlayer may need to be updated to reflect the need to restart NVDA after installing mathPlayer.
Testing strategy:
Known issues with pull request:
None
Change log entries:
Changes
For Developers
Code Review Checklist: