Link to issue number:

fixes #13457

Summary of the issue:

With UIA for Excel disabled, navigating to a cell with a formula and "has formula" is not reported.
This is a regression caused by #13414

In NVDAHelper/remote/excel.cpp the properties of a cell are determined and bits are set on the state member of a EXCEL_CELLINFO struct.
The constatnts used for this are in NVDAHelper/remote/excel/Constants.h, see the NVSTATE_* constants, previously these matched the controlTypes.State constants directly.

Description of how this pull request fixes the issue:

Rather than couple the excel implementation to the controlTypes implementation, these constants have been converted to enums (both in C++ and in Python), renumbered, and an explicit mapping to the corresponding controlTypes.State enum has been created.

Testing strategy:

• Added a unit test to ensure all cellState values are mapped.
• Manually tested Excel with formula and comments on cells (both with UIA and without).

Known issues with pull request:

None

Change log entries:

For Developers

- Excel cell state constants (``NVSTATE_*``) are now values in the ``NvCellState`` enum, mirrored in the ``NvCellState`` enum in ``NVDAObjects/window/excel.py`` and mapped to ``controlTypes.State`` via _nvCellStatesToStates.
- ``EXCEL_CELLINFO`` struct member ``state`` is now ``nvCellStates``.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English