Skip to content

HID Braille driver: allow performing chorded gestures (space+dots)#13326

Merged
michaelDCurran merged 2 commits into
masterfrom
fixHidBrailleChordGestures
Feb 10, 2022
Merged

HID Braille driver: allow performing chorded gestures (space+dots)#13326
michaelDCurran merged 2 commits into
masterfrom
fixHidBrailleChordGestures

Conversation

@michaelDCurran

Copy link
Copy Markdown
Member

Link to issue number:

None.

Summary of the issue:

When using a Braille display in NVDA via HID braille, it was impossible to perform chorded gestures, that is space with other dots. E.g. space+dot4 to move down by line.

Description of how this pull request fixes the issue:

Fix an indenting error which caused only the last key in a chorded gesture to be listed in the BrailleGesture's id.

Testing strategy:

  • Connected to an Orbit Reader 40 in HID Braille mode.
  • Opened a web page in browse mode.
  • Pressed space+dot4 to move down by line.
  • Confirmed the braille display showed the new line.

Also:

  • With log level set to input/output,
  • Performed multiple chorded gestures, confirming that the logged gesture identifiers contain both space and dots (E.g. br(StandardHid):space+dot4. Previously it whould only say br(StandardHid):space.

Known issues with pull request:

None known.

Change log entries:

New features
Changes
Bug fixes

  • HID braille: chorded gestures (E.g. space+dot4) can be successfully performed from the Braille display.
    For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

…o an indenting error gesture names were only being generated for only one of the keys in the chord.
@michaelDCurran michaelDCurran requested a review from a team as a code owner February 10, 2022 04:49
@michaelDCurran michaelDCurran merged commit 65b0f0c into master Feb 10, 2022
@michaelDCurran michaelDCurran deleted the fixHidBrailleChordGestures branch February 10, 2022 05:50
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants