Skip to content

Remove deprecated SYMLVL constants from characterProcessing#13248

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:characterProcessingRemoveDeprecatedConstants
Jan 18, 2022
Merged

Remove deprecated SYMLVL constants from characterProcessing#13248
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:characterProcessingRemoveDeprecatedConstants

Conversation

@lukaszgo1

@lukaszgo1 lukaszgo1 commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

Removes code deprecated as part of PR #11856

Summary of the issue:

PR #11856 converted module level constants for symbol levels in characterProcessing into an enum. The constants were marked for removal in 2022.1.

Description of how this pull request fixes the issue:

These constants are removed.

Testing strategy:

With git grep made sure that the removed symbol levels are not used in the source code.

Known issues with pull request:

None known

Change log entries:

For Developers

  • characterProcessing.SYMLVL_* constants are removed - please use characterProcessing.SymbolLevel.* instead.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner January 17, 2022 17:22
@lukaszgo1 lukaszgo1 requested a review from seanbudd January 17, 2022 17:22
@seanbudd seanbudd merged commit c49929d into nvaccess:master Jan 18, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Jan 18, 2022
@lukaszgo1 lukaszgo1 deleted the characterProcessingRemoveDeprecatedConstants branch January 18, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants