Prefer Difflib in scrolling LiveText objects#12974
Merged
Merged
Conversation
21b7ee5 to
fde3656
Compare
…ably override this choice.
fde3656 to
37cdec6
Compare
seanbudd
requested changes
Oct 27, 2021
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
seanbudd
approved these changes
Oct 27, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
@Qchristensen - what are your thoughts on the docs changes?
See test results for failed build of commit 2bb94a9c51 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
seanbudd
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Twitter thread.
Summary of the issue:
In
LiveTextobjects that are constrained to onscreen text (i.e. where text scrolls off the screen), DMP is sometimes unable to correctly calculate new text, leading to choppy and inconsistent new text reporting.Description of how this pull request fixes the issue:
Prefer Difflib in pre-
FORMATTEDUIA console (including legacy mode) andDisplayModelLiveTextobjects. Users can override this choice in advanced settings for testing or if DMP really provides a supperior experience in their situation.Testing strategy:
Tested the following scenarios:
FORMATTEDWindows ConsoleFORMATTEDWindows ConsoleFORMATTEDWindows ConsoleIMPROVEDWindows ConsoleIMPROVEDWindows ConsoleIMPROVEDWindows ConsoleEND_INCLUSIVEWindows ConsoleEND_INCLUSIVEWindows ConsoleEND_INCLUSIVEWindows ConsoleKnown issues with pull request:
None known.
Change log entries:
== Bug Fixes ==
== Changes for Developers ==
diffHandler.get_dmp_algoanddiffHandler.get_difflib_algorenameddiffHandler.prefer_dmpanddiffHandler.prefer_difflibrespectively.Code Review Checklist: