Skip to content

Bump comtypes to 1.1.11#12953

Merged
seanbudd merged 7 commits into
nvaccess:masterfrom
LeonarddeR:bumpComtypes
Jun 21, 2022
Merged

Bump comtypes to 1.1.11#12953
seanbudd merged 7 commits into
nvaccess:masterfrom
LeonarddeR:bumpComtypes

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Oct 18, 2021 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Description of this pull request

Updates Comtypes to version 1.1.11.

Changelog

Release 1.1.11
--------------
 * Fix setuptools>=57.5.0 compatibility. Thanks @kdschlosser.
 * Fix timestamping for typelib. Thanks @fusentasticus.
 * Fix 64bit inproc server. Thanks @klusidy.
 * Drop Python 2.6 support (Python 2.7 is still supported).
 * Fix IndexError for empty safearray. Thanks @BALOGHBence.
 * Make numpy typecodes consistent across numpy versions. Thanks @bennyrowland.

Release 1.1.10
--------------
 * Fix loading module from relative path on Windows 7.

Release 1.1.9
-------------
 * Fix loading module from relative path.
 * Use comtypes release version in code generator version check.

Testing strategy:

Should run for a while in Alpha.

Known issues with pull request:

None known

Change log entries:

For Developers

  • Updated Comtypes to version 1.1.11.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@LeonarddeR LeonarddeR requested a review from a team as a code owner October 18, 2021 16:12
@AppVeyorBot

AppVeyorBot commented Oct 18, 2021

Copy link
Copy Markdown

See test results for failed build of commit 788ba87ab6

@LeonarddeR LeonarddeR marked this pull request as draft October 18, 2021 16:31
@LeonarddeR LeonarddeR mentioned this pull request Nov 3, 2021
Merged
20 tasks
@OzancanKaratas

OzancanKaratas commented Feb 15, 2022

Copy link
Copy Markdown
Collaborator

@LeonarddeR please consider updating to version 1.1.11.

LeonarddeR
LeonarddeR commented Feb 18, 2022
View reviewed changes
Comment thread requirements.txt Outdated
@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.10 Bump comtypes to 1.1.11 Feb 18, 2022
@LeonarddeR

LeonarddeR commented Feb 18, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks @OzancanKaratas

@AppVeyorBot

AppVeyorBot commented Feb 18, 2022

Copy link
Copy Markdown

See test results for failed build of commit b1e531b550

@OzancanKaratas

OzancanKaratas commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

A bug fix version (1.1.12) has been released.

@seanbudd

seanbudd commented Jun 21, 2022

Copy link
Copy Markdown
Member

@LeonarddeR - what is holding this back from being merged?

@seanbudd seanbudd requested review from seanbudd and removed request for michaelDCurran June 21, 2022 02:44
@LeonarddeR LeonarddeR marked this pull request as ready for review June 21, 2022 05:46
@LeonarddeR

LeonarddeR commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator Author

In my opinion it would benefit from #13048. Now that's merged, I think we're good to go.

@seanbudd

seanbudd commented Jun 21, 2022

Copy link
Copy Markdown
Member

@LeonarddeR - it appears there is a 1.1.12 now, should we update to that instead?

@LeonarddeR

LeonarddeR commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator Author

I hadn't seen that one, makes sense.

@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.11 Bump comtypes to 1.1.12 Jun 21, 2022
@LeonarddeR LeonarddeR changed the title Bump comtypes to 1.1.12 Bump comtypes to 1.1.11 Jun 21, 2022
@LeonarddeR

LeonarddeR commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator Author

I'm seeing weird behavior with Comtypes 1.1.12 not populating com interfaces correctly. Furthermore, it's not available on PyPI. Lets stick to 1.1.11

@seanbudd

seanbudd commented Jun 21, 2022

Copy link
Copy Markdown
Member

@LeonarddeR - I realise now that they are probably staged changes for a future 1.1.12 release, as the file linked is the changelog on master

@AppVeyorBot

AppVeyorBot commented Jun 21, 2022

Copy link
Copy Markdown

See test results for failed build of commit 1c803b5204

@AppVeyorBot

AppVeyorBot commented Jun 21, 2022

Copy link
Copy Markdown

See test results for failed build of commit 1c803b5204

@seanbudd seanbudd merged commit 713cdc0 into nvaccess:master Jun 21, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.3

Development

Successfully merging this pull request may close these issues.

5 participants

@LeonarddeR @AppVeyorBot @OzancanKaratas @seanbudd @nvaccessAuto