Add logging to SAPI5 synthDriver and move constants to Enums#12927
Merged
Conversation
michaelDCurran
requested changes
Oct 20, 2021
Co-authored-by: Michael Curran <mick@nvaccess.org>
michaelDCurran
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
While debugging #12913, I created some Enums and added more logging.
This is not a focused refactor, and as such, more work could be done to improve the SAPI 5 driver.
Description of how this pull request fixes the issue:
IntEnums for constantsTesting strategy:
Test the SAPI5 synthesizer
Known issues with pull request:
#12913
Note, this is an API breaking change and should not be merged until 2022.1.
I have just created this PR as the work should not be lost, but adding backwards compatibility is not worth prioritising.
Change log entries:
See diff in changes.t2t
Code Review Checklist: