create Enums for audioDucking and minor lint#12926
Merged
Merged
Conversation
michaelDCurran
requested changes
Oct 20, 2021
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
Looks good other than the query re _displayStringLabels
| self.duckingList = settingsSizerHelper.addLabeledControl( | ||
| duckingListLabelText, | ||
| wx.Choice, | ||
| choices=audioDucking.AudioDuckingMode._displayStringLabels.values() |
Member
There was a problem hiding this comment.
does this really work?
I think that _displayStringLabels is an instance property, and therefore can not be accessed on the class, rather it can only be accessed on the instance (one of the enum values).
Member
Author
There was a problem hiding this comment.
No, this doesn't work. I've tested this PR using a try build now, and fixed how the choices are generated
# Conflicts: # user_docs/en/changes.t2t
michaelDCurran
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
While debugging #12913, I created some Enums to help with logging and understanding the code.
This is not a focused refactor, and as such, more work could be done to improve the audioDucking API.
Description of how this pull request fixes the issue:
IntEnums for constantsTesting strategy:
with a try build of this PR:
Known issues with pull request:
Note, this is an API breaking change and should not be merged until 2022.1.
I have just created this PR as the work should not be lost, but adding backwards compatibility is not worth prioritising.
Change log entries:
See diff in changes.t2t
Code Review Checklist: