Use WordDocument of Winword appModule both with IAccessible and UIA.#12904
Merged
Conversation
Member
|
This pr now builds. Any remaining reason why this is a draft? |
michaelDCurran
approved these changes
Oct 5, 2021
Contributor
Author
|
It was in draft since I still had to test on the older version of Word (IAccessible). It is now done and I have updated the initial description accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Fix-up of #11824.
Summary of the issue:
The class
appModules.winword.WinwordWordDocumentis used only in Word if using IAccessible, whereas it should be used with both IAccessible and UIA. This leads to the following consequences when using UIA for Word:appModules.winword.WinwordWordDocumentis used in somegestures.inifiles (fr, it, pt_PT) to localize scripts corresponding to shortcuts that operate only in Word, not in Outlook; e.g. ctrl+R that performs left paragraph indent in French Word instead of left paragraph alignment in French Outlook.Description of how this pull request fixes the issue:
Use the class
appModules.winword.WinwordWordDocumentwith both IAccessible and UIA.Testing strategy:
Perform the following two tests with the following versions of Word 2016:
Test 1:
Test that the toggle change tracking is reported when pressing the corresponding shortcut (specifically ctrl+shift+R on my French Office version).
Note: for anyone wanting to test on English Office and NVDA, the shortcut is ctrl+shift+E.
Test 2:
On French Word and French NVDA, test that the script increasing left paragraph indent reports the new indentation when the corresponding shortcut is pressed.
Note: Cannot be tested on English versions of Word and NVDA. Similar tests can be done however for Italian and Portuguese (pt_PT).
Known issues with pull request:
None
Change log entries:
Bug fixes
When accessing MS Word with UIA, , change tracking command and some other localized commands are now reported in Word . (#12904)Code Review Checklist: