Announce highlight instead of marked#12892
Merged
Merged
Conversation
Contributor
Author
|
Marked (highlight) isn't announced in focus mode (as shown by the system test). I'll consider whether this is appropriate next. |
This comment has been minimized.
This comment has been minimized.
michaelDCurran
approved these changes
Oct 6, 2021
seanbudd
approved these changes
Oct 6, 2021
Contributor
|
This PR can solve #12101? |
Contributor
Author
|
No @cary-rowen, this is specifically about the text used when reporting role_mark. |
seanbudd
pushed a commit
that referenced
this pull request
Nov 2, 2021
5 tasks
seanbudd
added a commit
that referenced
this pull request
Nov 3, 2021
Follow up of #12892 Summary of the issue: A usage of "marked text" still remains, while other usages have been replaced with "highlighted text" Description of how this pull request fixes the issue: Replaces marked text with highlighted text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Perhaps #4247 can be closed?
Prior work: #11436
Summary of the issue:
'mark' elements were being reported as "marked content".
This is long. Additionally, the standard visual representation of
markis a yellow background, as if the text has been highlighted.Arguably, "highlighted" is a more common phrase in English.
It is also more specific to this visual representation.
The more generaral "marked" content could mean many different kinds of markings with varied semantics.
With the introduction of "role-description", less common usages of
markcan be achived.Description of how this pull request fixes the issue:
Use "highlight" instead of "marked content" for speech.
Use "hlght" instead of "mrkd" for braille
Testing strategy:
System tests
Known issues with pull request:
Some users may already be familiar with "marked content".
Change log entries:
Changes
Code Review Checklist: