Update liblouis to 3.19.0#12810
Conversation
|
It'd be great to include this PR into 2021.3 if possible. |
|
In this release the back translation in Russian uncontracted braille was added. Can you, please, remove |
Thanks! I had forgotten about it.
Also done. But something is bugging me: |
It doesn't work like in English braille, for example. As the contracted braille isn't used in Russia oficially, we don't call literary braille "uncontracted" (a lot of people won't understand it). But the system of contracted braille was developed and now consists of two grades: grade 1 (partial contraction which includes syllables, prepositions, etc. and grade 2 which includes full words). |
|
@Futyn-Maker Thank for clarifying! Maybe should we add " (partial)" to the display-name (in NVDA)? |
|
@AAClause maybe later, if the grade 2 table will be made. |
|
NVDA uses "grade 0" in English to refer to uncontracted German Braille. For consistency, I think "grade 0" is appropriate. |
|
Maybe this is acceptable for English names of these tables, but then these names shouldn't be translated on Russian like "нулевая ступень" (grade 0) as it can result in confusions for users. |
It does so only because German braille standard refers to uncontracted Braille as grade 0. Regardless of that I don't think consistency should be a factor here. When naming LibLouis tables we should remain as close to names used in LibLouis because we're not familiar with particular Braille codes being implemented, and since someone named these tables in a particular way they presumably did so in accordance with the local Braille jargon which in turn ensures that for users of these tables they can tell from the name what notation the given table implements. |
|
@michaelDCurran Are you planning to review this in time for 2021.3? |
See test results for failed build of commit be76e20d12 |
Link to issue number:
None
Summary of the issue:
Liblouis 3.19.0 has been released.
Description of how this pull request fixes the issue:
Updates liblouis to 3.19.0 which adds 3 new braille tables, fixes several bugs and cleans the codebase. Changelog.
Testing strategy:
Played with new braille tables and some others (input and output). Everything works as expected.
Known issues with pull request:
None
Change log entries:
Section: Changes
Code Review Checklist: