Ensure that clipboard manager does not steal focus when starting MS Office programs#12736
Conversation
|
@michaelDCurran Have you seen this? The person who reported this problem to me asked if it would be possible to get this bug fix into 2021.3 that's why I've decided to ping you again. |
|
@michaelDCurran Given the small size of this PR it would be a real pity not to get it into 2021.3. Is there anything which can be done on the author side (aside from pinging you from time to time and hoping you would look at the code) to avoid small fixes like this being stuck for several months? |
|
Hi, Is this unique to this user or can others reproduce this? I cannot seem to reproduce this - when I run Excel from Run dialog, Excel opens to Home screen (this is on Excel 365). |
|
It is reproducible for both the user who reported this to me and on my machine (in my case on Win 7) in theirs on Win 10 20H2. I'm not sure what is different perhaps version of Office or specific things set in Excel's settings. At any rate even if this would be reproducible only for original reporter assuming this fix has no adverse side effects there is no reason not to merge it IMO. |
|
Hi, I think asking about this on users list would be great. @britechguy, thoughts? Thanks.
|
|
@josephsl I really really don't want to over engineer this. Two people confirmed that the problem exists and then two people confirmed that this fix works. Waiting for additional confirmations which as it so often happens when asking users for tests never comes can only results in additional delays. As it is this PR is very simple and awaits review for almost two months. If you have specific problems with this fix then I'm happy to discuss / implement it differently. |
|
Hi, at least asking around could help us point out other possible reasons for this PR – at least that’s the ideal situation, but I do understand that delay in review and merge reduces productivity. I’m not looking at overengineering it – I just simply want to see data that says this problem has potential to affect more people if not mitigated, which was justified in the overall PR discussion. Hope this clarifies things.
|
|
When it comes to something that impacts users, and where even some small
subset may be willing to do "field testing," I think discussion on the user
group is perfectly fine.
The above being said, I had not been involved with this issue before, and
when I went to look at it I am left slightly confused, and I think it's the
result of a typo. The title of the issue is: Ensure that clipboard
manager does not still focus when starting MS Office programs
When looking through the issue and comments, it appears to me that the
"still" should be "steal" but, it's possible though way less likely, it
could be "stall." But "still focus" makes no sense, at least not to me.
Brian
…On Wed, Oct 6, 2021 at 2:17 PM Joseph Lee ***@***.***> wrote:
Hi, I think asking about this on users list would be great. @britechguy,
thoughts? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12736 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENFMHWYZG4TH7HPBJ52YJTUFSHDBANCNFSM5CFE4MDA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Bri the Tech Guy* *http://britechguy.com <http://britechguy.com>*
brite ***@***.******@***.*** ***@***.***>
phone/text: *(540) 324-5032 <+1-540-324-5032>*
"*If it's got you screaming, I'll help you stop!!*"
|
|
still -> steal |
19a7a3f to
936b7d2
Compare
|
Given the small size of this PR and how early in the release cycle it has been submitted it is a real shame it didn't get into 2021.3 @michaelDCurran Can we at least have this added into 2022.1 so this is not forgotten once again? |
|
Hi, another option might be to target beta branch. Thanks.
|
I don't think this fix is important enough to go to beta at this stage. My last comment was more of a "I don't think this PR has been handled well" thing rather than "This PR is important and should be in 2021.3". |
Link to issue number:
None, related to #4199, Originally reported on one of the Polish mailing lists (I cannot link to the conversation archives cannot be accessed for non subscribers)
Summary of the issue:
As described in #4199 when starting Office programs Word, Excel clipboard manager can sometimes steal accessibility focus making it impossible to interact with the document / spreadsheet.
Most cases were fixed but it seems one has been missed - focus lands on something called Collect and Paste 2.0 ,making interaction with the actual document difficult.
Description of how this pull request fixes the issue:
Since the "Collect and paste" has a custom eventObjectID
SDM~has not been applied to it causing focus to be incorrect. This custom ID has been added to the list of objects for whichSDM~applies.Testing strategy:
Started Excel from the run box - made sure that focus lands on the actual spreadsheet whereas previously it didn't.
Known issues with pull request:
None known
Change log entries:
Bug fixes
Code Review Checklist: