Link to issue number:

None

Summary of the issue:

In the past, we had to explicitly dig up the dirs where clang was installed inside Visual Studio. It looks like since then, Microsoft added LLVM to the path of the Visual Studio tools command prompt, which constructor batch file is used by SCons.

Description of how this pull request fixes the issue:

No longer add Clang to the path. Note that we still check its installation.

I also updated the readme according to the new design of the Visual Studio installer, thereby changing the following:

1. As a minimum, version 16.11 is recommended which is the most recent version of Visual Studio 2019. This is not yet available on appveyor at the time of writing, but version 16.10 will only be supported for three months or so. I assume Appveyor will switch to 16.11 asap.
2. The installer has a new design with list/tree view instead of a bunch of groupings you have to tab through.
3. I appended a note about the build tools for those who don't require the IDE. This works like a charm and saves some unnecessary space on ones hard drive.

Testing strategy:

Tested that NVDA builds with Visual Studio build tools 16.11

Known issues with pull request:

None known

Change log entries:

Changes for developers:

• Building NVDA now requires Visual Studio 2019 16.10 or later. To build NVDA successfully, update Visual Studio to keep in sync with the [current AppVeyor build version https://www.appveyor.com/docs/windows-images-software/#visual-studio-2019]. (No longer append clang directories to path in SCons environment when building liblouis and update readme about Visual Studio #12728)

Code Review Checklist:

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual testing.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers