Skip to content

Update eSpeak to 74068b91bcd578#12665

Merged
seanbudd merged 2 commits into
masterfrom
updateEspeakFor2021.3
Jul 21, 2021
Merged

Update eSpeak to 74068b91bcd578#12665
seanbudd merged 2 commits into
masterfrom
updateEspeakFor2021.3

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 21, 2021

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

It is helpful to run the latest version of espeak.

Description of how this pull request fixes the issue:

This seems to add support for 2 constructed languages from JRR Tolkien's LOTR.

Testing strategy:

  • Diff the files as per the strategy above
git diff ab11439b18238b7a08b965d1d5a6ef31cbb05cbb 74068b91bcd578bd7030a7a6cde2085114b79b44 Makefile.am
git diff ab11439b18238b7a08b965d1d5a6ef31cbb05cbb 74068b91bcd578bd7030a7a6cde2085114b79b44 --stat
  • NVDA builds, ensure espeak continues to work as expected

Known issues with pull request:

May reintroduce #12465. If this is the case, espeak-ng/espeak-ng#950 will need to be updated. This may remain an issue when updating espeak in future.

As a short term solution I'll do a revert. However, since there is no test case that works for me and @valdisvi the bug might be reintroduced by accident later. [revert commit]

Originally posted by @jaacoppi in espeak-ng/espeak-ng#950 (comment)

Change log entries:

See changes.t2t diff

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd requested a review from a team as a code owner July 21, 2021 06:49
@seanbudd seanbudd requested a review from michaelDCurran July 21, 2021 06:49
@seanbudd seanbudd changed the title update espeak to 74068b91bcd578bd7030a7a6cde2085114b79b44 update espeak to 74068b91bcd578 Jul 21, 2021
@seanbudd seanbudd changed the title update espeak to 74068b91bcd578 Ypdate eSpeak to 74068b91bcd578 Jul 21, 2021
@seanbudd seanbudd changed the title Ypdate eSpeak to 74068b91bcd578 Update eSpeak to 74068b91bcd578 Jul 21, 2021
@seanbudd seanbudd merged commit 38a2efd into master Jul 21, 2021
@seanbudd seanbudd deleted the updateEspeakFor2021.3 branch July 21, 2021 08:09
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants