UI Automation in Windows Console: add "API levels" as a better isImprovedTextRangeAvailable#12660
Merged
Merged
Conversation
Contributor
Author
|
Cc @carlos-zamora, @DHowett. |
4c0bfe9 to
e5ed7ce
Compare
e5ed7ce to
1a52c8a
Compare
7 tasks
Contributor
Author
|
Also CC @seanbudd. |
Collaborator
|
Would it be possible to determine the correct behavior based on the version of conhost available on the system? |
Contributor
Author
According to the conhost devs, version number is no longer a reliable indicator of functionality. |
LeonarddeR
reviewed
Jul 21, 2021
Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
seanbudd
approved these changes
Jul 22, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks for this, looks good to me
|
I think this is such a good way to do this. I'm always an advocate for feature detection rather than versioning, especially since Windows' servicing story makes it ... difficult to pin down precise time ranges 😄. Thanks @codeofdusk! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The Windows 11 inbox console will ship with most, but not all, fixes required to make UIA by default a good experience. However, a new conhost version will be delivered "out-of-box" including additional functionality and bug fixes. Therefore,
isImprovedTextRangeAvailable(a boolean value) is now insufficient to express the range of possible UIA console versions now in the wild.Description of how this pull request fixes the issue:
WinConsoleAPILevel, with comments describing the meaning of each member.isImprovedTextRangeAvailable, but refactor it for now to useapiLevel.Testing strategy:
Tested conhost versions meeting each API level and verified that the correct level was being set.
Known issues with pull request:
FORMATTEDlevel is intentionally unused in NVDA code, usage to follow in subsequent PRs.FORMATTEDconsoles are correctly detected when run though.Change log entries:
== Changes for Developers ==
NVDAObjects.UIA.winConsoleUIA.WinConsoleUIA.isImprovedTextRangeAvailablehas been deprecated. (UI Automation in Windows Console: add "API levels" as a better isImprovedTextRangeAvailable #12660)apiLevel(see the comments at _UIAConstants.WinConsoleAPILevel for details).Code Review Checklist: