appModules/SearchUI: add 'searchhost' as an alias of Search UI app module in Windows 11#12628
Merged
Conversation
…dows 11. Windows Search executable was renamed to searchhost.exe in Windows 11, affecting suggestion count announcement. Therefore add an alias app module to support Windows 11.
seanbudd
reviewed
Jul 9, 2021
Note from Sean Budd (NV Access): use __all__ to specify module attributes and to avoid Flake8 NOQA comment in the process. Co-authored-by: Sean Budd <seanbudd123@gmail.com>
seanbudd
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Another part of #12585:
Link to issue number:
Expands #10341
Summary of the issue:
Windows Search executable was renamed to searchhost.exe in Windows 11, affecting suggestion count announcement.
Description of how this pull request fixes the issue:
Add an alias app module named "searchhost.py" to support suggestions count announcement in Windows 11.
Testing strategy:
Manual testing:
Known issues with pull request:
None
Change log entries:
Tweaking #10341 to say:
New features:
In Windows 10 Version 1909 and later (including Windows 11), NVDA will announce suggestion count when performing searches in File Explorer. (#10341, #12628)
Code Review Checklist: