Fix for some grade 2 braille tables that are not declared as contracted#12541
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
don't worry about that system failure. I've redone the build for you. |
Member
|
@AAClause - was this a problem in the last release, or is this an unreleased issue? If it is unreleased (not in beta or 2020.4), we don't need to update the changelog on this I think. |
LeonarddeR
approved these changes
Jun 22, 2021
Contributor
Author
|
@seanbudd This is an issue present for quite some time (not introduced in the latest release). According to the |
seanbudd
approved these changes
Jun 23, 2021
Member
|
Thanks @AAClause and @LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up #12526 (comment)
Summary of the issue:
There are some grade 2 braille tables that are not declared as contracted. As a result the braille input does not work well with these tables.
Description of how this pull request fixes the issue:
Just adds
contracted=Trueto the corresponding tables.Testing strategy:
Ran from sources, set "Spanish grade 2" as input braille table and tried several inputs.
Known issues with pull request:
None
Change log entries:
Section: Bug fixes
- The braille input works properly with the following contracted tables: Arabic grade 2, Spanish grade 2, Urdu grade 2, Chinese (China, Mandarin) grade 2. (#12541)Code Review Checklist: