There are several grade 2 tables that are not declared as contracted. I think these are mistakes. Here are the corresponding lines (git blame format):

ec877feab2 (Leonard de Ruijter 2018-12-06 03:48:12 +0100 105) addTable("ar-ar-g2.ctb", _("Arabic grade 2"))
ec877feab2 (Leonard de Ruijter 2018-12-06 03:48:12 +0100 222) addTable("es-g2.ctb", _("Spanish grade 2"))
83738d7d91 (André-Abush Clause 2021-03-22 11:15:08 +0100 444) addTable("ur-pk-g2.ctb", _("Urdu grade 2"))
d1ba63ab8f (Leonard de Ruijter 2018-09-04 07:46:41 +0200 459) addTable("zhcn-g2.ctb", _("Chinese (China, Mandarin) grade 2"))

Should I make another Pull Request for that?

CC @LeonarddeR

Hello! Can it be included in NVDA 2021.1? Or Or is it too late?

I'm afraid it's too late for that.

Thanks again, this looks like a great update! I noticed that the "PR description is up to date is unticked. Can you say why that is? Is it because we are uncertain of the following known issue:

There are several grade 2 tables that are not declared as contracted. I think these are mistakes.

@LeonarddeR @AAClause - should we proceed with this given the raised issue?

Hello! Can it be included in NVDA 2021.1? Or Or is it too late?

Sorry, this will have to wait until 2021.2.

@LeonarddeR @AAClause - should we proceed with this given the raised issue?

That's my question :). Only 4 SLOC are affected but given that it is not related to liblouis 3.18 it's likely irrelevant in this PR (?).

Also I'd like to suggest to change the display names of some braille tables in the GUI, like this:

• Northern Kurdish grade 0 → Kurdish (Northern) grade 0
• Central Kurdish grade 1 → Kurdish (Central) grade 1
• Southern Vietnamese grade 1 → Vietnamese (Southern) grade 1

This way all Kurdish and Vietnamese tables would be gathered (currently scattered due to alphanumeric sorting). What do you think?

That's my question :). Only 4 SLOC are affected but given that it is not related to liblouis 3.18 it's likely irrelevant in this PR (?).

Cool, I will wait to see what @LeonarddeR thinks as well.

This way all Kurdish and Vietnamese tables would be gathered (currently scattered due to alphanumeric sorting). What do you think?

I agree, that would also be a good change. Might be worth noting that it differs to liblouis in a comment if that is the case.

I think it would be best to merge this pr as is. @AAClause raises valid points and therefore it makes sense to address them, but preferably in a follow up.