Update espeak to latest master#12449
Merged
Merged
Conversation
Updated to commit f6d092a9c13d864ede78c493f64a7d32cde41f09
michaelDCurran
requested changes
May 21, 2021
| 1. Change back to the NVDA repo root | ||
| 1. Update the package version in `<nvda repo root>/nvdaHelper/espeak/config.h` | ||
| 1. Update the `/DPACKAGE_VERSION` in `espeak/sconscript` | ||
| - The preprocessor definition is used to create `<nvda repo root>/nvdaHelper/espeak/config.h` |
Member
There was a problem hiding this comment.
I don't think this statement is quite correct. The preprocessor definitions are specified on the commandline instead of in config.h. config.h is empty and stays empty.
Contributor
Author
There was a problem hiding this comment.
Yes, "instead of" would be more clear. I guess config.h still has to exist, even if empty.
michaelDCurran
requested changes
May 21, 2021
michaelDCurran
approved these changes
May 21, 2021
Contributor
Author
|
Follow up to re-introduce Cantonese and Mandarin for espeak: #12370 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In order to start getting feedback as soon as possible before making a beta release, we can update espeak (and merge back to alpha).
If no problems are found for alpha users over the weekend we will use this version of espeak in the beta release.
Once this version of espeak is accepted we will work on fixing Cantonese and Mandarin voices.
Description of how this pull request fixes the issue:
Updates Espeak-ng to latest master commit f6d092a9c13d864ede78c493f64a7d32cde41f09
Testing strategy:
Build and run locally, with espeak voice
Feedback from alpha users over the weekend
Known issues with pull request:
Change log entries:
Changes
Update existing specify new commit: f6d092a9c13d864ede78c493f64a7d32cde41f09
Code Review Checklist: