Speech Viewer: allow to close with alt+F4 & add a close button on the title bar for use with pointing devices (#10791)#12330
Conversation
… title bar for use with pointing devices (nvaccess#10791)
seanbudd
left a comment
There was a problem hiding this comment.
Looks good to me, but I seem to be unable to add the changelog update to changes.t2t - I'm guessing that the box to allow edits from maintainers isn't checked. Could you insert the changelog update or check this?
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
|
@seanbudd wrote:
Sadly, this box is only available for PRs made from forks owned by users but not for forks owned by organizations. |
…tions/nvda into i10791-speechViewerCloseButton
seanbudd
left a comment
There was a problem hiding this comment.
Looks good now, thanks for adding me to the repo
Link to issue number:
Fixes #10791
Summary of the issue:
The Speech Viewer currently has no close button nor can be closed with alt+F4.
As described by @Qchristensen in #10791 (comment), most dialogs in NVDA can be closed with alt+F4.
As argued by @bhavyashah in #10791 (comment), the Speech Viewer is especially useful for sighted testers who might be more familiar in using pointing devices than keyboard shortcuts.
Description of how this pull request fixes the issue:
Handle closing with alt+F4 & add a standard close button in the title bar of the dialog.
Testing strategy:
Tested all combinations of "show on start-up" and not, opening/closing with the menu/gesture/button of both Speech and Braille viewers.
Ensured the checked state of the menu entry does reflect the state of the dialog.
Known issues with pull request:
It might be interesting to make the dialog freeze then forcibly close it to ensure the menu entry checked state remains consistent in that case.
Change log entries:
Changes
The Speech Viewer can now be closed with
alt+F4and has a standard close button for easier interaction with users of pointing devices. The other ways of interacting with this dialog remain otherwise unchanged.Code Review Checklist: