Braille Viewer: Add a close button on the title bar for use with pointing devices#12328
Conversation
|
This change IMHO does not deserve a change log entry.
I (mildly) disagree. Someone who has previously been frustrated by its absence,
may like to learn that now it's there.
|
|
I agree with @XLTechie, I think it could be useful for people to be aware of this new feature. |
|
@XLTechie, @alexarnaud, |
|
Can it also be reached by keyboard nav (either standard or braille)? |
|
@XLTechie wrote:
Only through object navigation. It is a standard dialog close button positioned at the right of the title bar and has no special UX whatsoever. It's sole intent is to be activated using a pointing device such as mouse or touch screen. Still, feel of course really free to propose a better wording of the change log entry than the one I quickly wrote. |
seanbudd
left a comment
There was a problem hiding this comment.
LGTM, thanks @JulienCochuyt!
Link to issue number:
As argued IMHO with reason by @bhavyashah in #10791 (comment)
This PR does not address #10791 which targets Speech Viewer.
Summary of the issue:
The Braille Viewer currently presents no close control on its GUI.
It can only be closed with
alt+F4or by means of the dedicated NVDA Tools menu entry.Description of how this pull request fixes the issue:
Add a standard close button on the title bar of the Braille Viewer dialog.
Testing strategy:
Ensured the dedicated check-able NVDA Tools menu entry gets unchecked as it properly does when closing the dialog with
alt+F4.Ensured proper behavior is maintained during restarts with or without "show at start-up" being checked.
Known issues with pull request:
Change log entries:
Changes
The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. The other ways of interacting with this dialog remain otherwise unchanged.
Code Review Checklist: