remove wx.CENTER_ON_SCREEN and wx.CENTRE_ON_SCREEN#12309
Merged
Conversation
This was referenced Apr 19, 2021
michaelDCurran
approved these changes
Apr 20, 2021
Member
|
Could you please change the title of this pr to reflect that this removes deprecated constants, rather than deprecating them. Currently the title is "deprecate wx.CENTER_ON_SCREEN and wx.CENTRE_ON_SCREEN" which is not quite true. |
feerrenrut
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
We included code to add backwards compatibility for addons for the following deprecated wxPython constants
wx.CENTER_ON_SCREEN = wx.CENTRE_ON_SCREENwhen used withDialog.Center()Description of how this pull request fixes the issue:
Remove the deprecated code, and it's only usage in
AskAllowUsageStatsDialog, replace withself.CentreOnScreen()Testing strategy:
Search code for usages of
CENTRE_ON_SCREENandCENTER_ON_SCREENEnsure the following dialog centres properly in the NVDA python console
Known issues with pull request:
None
Change log entry:
Developer changes
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.