Use DriverSetting classes from autoSettingUtils rather than from driverHandler#12168
Merged
Conversation
See test results for failed build of commit 49dd4e897c |
This was referenced Mar 14, 2021
seanbudd
approved these changes
Mar 17, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I can confirm that the usages have been removed by searching through code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, removes code marked as kept for backwards compatibility in #10082
Summary of the issue:
PR #10082 refactored
driverHandlerand moved most of its content to a separate packageautoSettingUtils. To preserve backwards compatibility most ofautoSettingUtilswere imported todriverHandlerand these classes were used fromdriverHandlerthrough the code.Since 2021.1 is going to break add-ons anyway it makes sense to standardize this and remove these imports from
driverHandler.Description of how this pull request fixes the issue:
Unused imports are removed from
driverHandlerand all classes which were previously used from there are used fromautoSettingUtils.Testing strategy:
Inspected all usages of
driverHandlerwith git grep - ensured that no usages of code fromautoSettingUtilsremains.Known issues with pull request:
None known
Change log entry:
Section: changes for developers:
driverHandler- please use them fromautoSettingUtilsCode Review Checklist: