Skip to content

remove getSpeechForSpelling alias for getSpellingSpeech#12145

Merged
seanbudd merged 4 commits into
masterfrom
dep-10593
Mar 11, 2021
Merged

remove getSpeechForSpelling alias for getSpellingSpeech#12145
seanbudd merged 4 commits into
masterfrom
dep-10593

Conversation

@seanbudd

@seanbudd seanbudd commented Mar 10, 2021

Copy link
Copy Markdown
Member

Link to issue number:

Part of #12123

Implements deprecation announced in: #10593

Summary of the issue:

speech.getSpeechForSpelling was deprecated a year ago

Description of how this pull request fixes the issue:

speech.getSpeechForSpelling is removed in favour of the equivalent alias speech.getSpellingSpeech

Testing strategy:

Search the code base for usages of getSpeechForSpelling and confirm there is none

find . -type f -name '*.py' -exec grep -P "\bgetSpeechForSpelling\b" {} +

General user testing in the alpha/beta stages will confirm lack of changes

Known issues with pull request:

None

Change log entry:

Developer Changes

-`speech.getSpeechForSpelling` has been removed - use `speech.getSpellingSpeech` (#12145)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd mentioned this pull request Mar 10, 2021
18 tasks
@seanbudd seanbudd self-assigned this Mar 10, 2021
@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 10, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 10, 2021
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 84f3453c0b

@seanbudd seanbudd merged commit 8e4b189 into master Mar 11, 2021
@seanbudd seanbudd deleted the dep-10593 branch March 11, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants