Conversation
See test results for failed build of commit 84f3453c0b |
michaelDCurran
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #12123
Implements deprecation announced in: #10593
Summary of the issue:
speech.getSpeechForSpellingwas deprecated a year agoDescription of how this pull request fixes the issue:
speech.getSpeechForSpellingis removed in favour of the equivalent aliasspeech.getSpellingSpeechTesting strategy:
Search the code base for usages of
getSpeechForSpellingand confirm there is noneGeneral user testing in the alpha/beta stages will confirm lack of changes
Known issues with pull request:
None
Change log entry:
Developer Changes
Code Review Checklist: