Skip to content

remove DriverSettingsMixin alias for AutoSettingsMixin#12144

Merged
seanbudd merged 3 commits into
masterfrom
dep-e8f8a
Mar 11, 2021
Merged

remove DriverSettingsMixin alias for AutoSettingsMixin#12144
seanbudd merged 3 commits into
masterfrom
dep-e8f8a

Conversation

@seanbudd

@seanbudd seanbudd commented Mar 10, 2021

Copy link
Copy Markdown
Member

Link to issue number:

Part of #12123

Implements deprecation announced in: e8f8a89

Summary of the issue:

gui.DriverSettingsMixin was deprecated a year ago

Description of how this pull request fixes the issue:

gui.DriverSettingsMixin is removed in favour of the equivalent alias gui.AutoSettingsMixin

Testing strategy:

Search the code base for usages of DriverSettingsMixin and confirm there is none

find . -type f -name '*.py' -exec grep -P "DriverSettingsMixin" {} +

General user testing in the alpha/beta stages will confirm lack of changes

Known issues with pull request:

None

Change log entry:

Developer Changes

-`gui.DriverSettingsMixin` has been removed - use `gui.AutoSettingsMixin` (#12144)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd requested a review from feerrenrut March 10, 2021 01:33
@seanbudd seanbudd mentioned this pull request Mar 10, 2021
18 tasks
@seanbudd seanbudd requested a review from michaelDCurran March 10, 2021 01:34
@seanbudd seanbudd self-assigned this Mar 10, 2021
@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Mar 10, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Mar 10, 2021
@seanbudd seanbudd merged commit 16b8333 into master Mar 11, 2021
@seanbudd seanbudd deleted the dep-e8f8a branch March 11, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants