Skip to content

Update liblouis to 3.17.0#12137

Merged
feerrenrut merged 4 commits into
nvaccess:masterfrom
AAClause:liblouis-3.17
Mar 22, 2021
Merged

Update liblouis to 3.17.0#12137
feerrenrut merged 4 commits into
nvaccess:masterfrom
AAClause:liblouis-3.17

Conversation

@AAClause

@AAClause AAClause commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Liblouis 3.17.0 has just been released.

Description of how this pull request fixes the issue:

Updates liblouis to 3.17.0 which adds Belarusian braille tables and other awesome things.

Testing strategy:

  • Ran from sources.
  • Tested new braille tables (input and output).

Known issues with pull request:

None

Change log entry:

Section: Changes

- Updated liblouis braille translator to [3.17.0 https://github.com/liblouis/liblouis/releases/tag/v3.17.0]. (#12137)
  - New braille tables: Belarusian literary braille, Belarusian computer braille, Urdu grade 1, Urdu grade 2.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@lukaszgo1

Copy link
Copy Markdown
Contributor

Thanks for this PR @AAClause
LibLouis 3.17 adds some small but important fixes to the Polish tables - users of Polish braille would appreciate this being merged in time for NVDA 2021.1.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 56fdd13e0f

@AAClause

AAClause commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

Why the system tests are randomly failing?

@LeonarddeR LeonarddeR added this to the 2021.1 milestone Mar 11, 2021
@feerrenrut

Copy link
Copy Markdown
Contributor

Does the change log entry for this PR need to refer to the Polish fixes @lukaszgo1 ?

@feerrenrut

Copy link
Copy Markdown
Contributor

Never mind @lukaszgo1 I think it is enough that the new tables are mentioned and the link to the release notes is included.

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AAClause

@feerrenrut feerrenrut merged commit 83738d7 into nvaccess:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants