Script decorator: add ability to specify that given script should be active in sleep mode.#11979
Merged
michaelDCurran merged 7 commits intoJan 11, 2021
Conversation
…ipt. * Also take this oportunity to use type hints for script decorator parameters
michaelDCurran
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None - discovered by @josephsl during his work on #11974
Summary of the issue:
It is impossible to specify that given script should be active in sleep mode for a script decorated with script decorator.
Description of how this pull request fixes the issue:
Script decorator now accepts additional parameter
allowInSleepModewhich just sets it on the script.While at it I've also added type hints to the list of its arguments and extended unit test to ensure that
allowInSleepModeworks.Testing performed:
I've decorated script which enables/disables sleep mode for a current app and set
allowInSlepModeto true ensuring that this script indeed works when in sleep mode. This code isn't in the PR as IMHO it makes sense to merge tis PR first and then perform the actual change as part of #11974.Known issues with pull request:
None known
Change log entry:
Changes for developers:
allowInSleeepModein the list of script decorator's-arguments.