Update CLDR to version 38.1#11943
Merged
Merged
Conversation
Collaborator
Author
|
Sorry for forgetting some changes. Please don't close this. We can merge it using patch. |
Collaborator
|
We're not going for beta with CLDR 38.1. It will have to be 2021.1 instead. |
Contributor
|
Hi, in addition, one important consideration: although things are not done with beta, we have to focus on stability. Although CLDR 38.1 may introduce new emoji characters, we have to give it a chance to be tested by testers, and beta is not a good branch at this time. This is more so now that 2020.4 beta 1 was just declared, which to me means stability takes priority (personally, I’m against applying dependency updates to beta branch when a beta cycle is active unless the dependency fixes an issue introduced in a beta release). Therefore, I’m in agreement with Leonard, and move to target 2021.1. Thanks.
|
Collaborator
Author
|
Ok, now it's ready for review. Thanks for the branch change @LeonarddeR. |
See test results for failed build of commit 56336148fa |
This comment has been minimized.
This comment has been minimized.
michaelDCurran
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge the beta branch.
@LeonarddeR @feerrenrut