You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In MS Word/Outlook browse mode, layout tables (i.e. tables with no border) are skipped when using table quick navigation key (T and shift+T), even if "Include layout tables" options is enabled in Browse mode settings.
Description of how this pull request fixes the issue:
In NVDAObjects\window\winword, I have modified the TableWinWordCollectionQuicknavIteratorfilter method so that the iterator returns a table if borders are enabled or if layout tables should be included.
I have checked in nvdaHelper\remote\winword.cpp that the presence or the absence of a border was already the criterion that defines if a table is a layout table or not. (so nothing done in this file)
Testing performed:
In MS word checked table quick navigation commands (T and shift+T):
with include layout tables enabled: they stop on any table
with include layout tables disabled: they stop on tables with borders but skip tables without borders
Known issues with pull request:
None
Change log entry:
Section: Bug fixes
In MS Word or Outlook, table quick navigation key can now jump to layout table if "Include layout tables" option is enabled in Browse mode settings (#11899).
In MS Word/Outlook browse mode, layout tables (i.e. tables with no border) are skipped when using table quick navigation key (Y and shift+Y), even if "Include layout tables" options is enabled in Browse mode settings.
Just to make sure - you mend T and Shift+T, right?
In MS Word/Outlook browse mode, layout tables (i.e. tables with no border) are skipped when using table quick navigation key (Y and shift+Y), even if "Include layout tables" options is enabled in Browse mode settings.
Just to make sure - you mend T and Shift+T, right?
Yes, sorry. I have modified the initial description with the correct shortcuts.
@seanbudd: just tried to convert to draft and ready again in order to have a reviewer assigned...
This PR is quite small so maybe it has still a chance to target 2021.1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In MS Word/Outlook browse mode, layout tables (i.e. tables with no border) are skipped when using table quick navigation key (T and shift+T), even if "Include layout tables" options is enabled in Browse mode settings.
Description of how this pull request fixes the issue:
In
NVDAObjects\window\winword, I have modified theTableWinWordCollectionQuicknavIteratorfiltermethod so that the iterator returns a table if borders are enabled or if layout tables should be included.I have checked in
nvdaHelper\remote\winword.cppthat the presence or the absence of a border was already the criterion that defines if a table is a layout table or not. (so nothing done in this file)Testing performed:
In MS word checked table quick navigation commands (T and shift+T):
Known issues with pull request:
None
Change log entry:
Section: Bug fixes
In MS Word or Outlook, table quick navigation key can now jump to layout table if "Include layout tables" option is enabled in Browse mode settings (#11899).