Skip to content

Script to toggle marked (highlighted) text reporting.#11807

Merged
michaelDCurran merged 5 commits into
nvaccess:masterfrom
CyrilleB79:scriptReportHighlighted
Nov 5, 2020
Merged

Script to toggle marked (highlighted) text reporting.#11807
michaelDCurran merged 5 commits into
nvaccess:masterfrom
CyrilleB79:scriptReportHighlighted

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

In #11436, the 'Marked (highlighted) text' option has been added to Document formatting settings panel.
Almost all document formatting settings option have a corresponding script. However in the case of marked text, there is no way to toggle this option quickly:

  • there is no associated script to toggle this option
  • there is even no accelerator key in the document formatting settings panel

When adding an option to document formatting settings, it seems important to me to have the corresponding toggle script since formatting reporting is only useful in some cases.

Description of how this pull request fixes the issue:

  1. Added the script to toggle this option in globalCommands.py. I have taken example on script_toggleReportSuperscriptsAndSubscripts since this script was recently added and reviewed in Add a script to toggle the report of superscripts and subscripts #10985. This script is unassigned by default.
  2. Added an accelerator key to 'Marked (highlighted) text' in the Document formatting settings panel. The letter K was choosen. It is also associated to 'clickable' checkbox. However, the Document formatting panel has many options and almost all letter of the alphabet are already defined as accelerator. It is still better than no accelerator at all.

Testing performed:

  1. Assigned the script, used it and checked opening the doc formatting settings panel the checkbox corresponding to this option.
  2. pressed alt+k in the doc formatting settings panel and checked that the focus moved to 'Marked text' checkbox.

Known issues with pull request:

None

Change log entry:

Section: New feature

Added a command to toggle reporting of marked (highlighted) text; no default associated gesture.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit e9cca1ac78

@michaelDCurran michaelDCurran merged commit 7e4d9fd into nvaccess:master Nov 5, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Nov 5, 2020
@CyrilleB79 CyrilleB79 deleted the scriptReportHighlighted branch November 5, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants