Remap F3 key for HIMS displays to avoi conflicts with number 6 in computer braille tables#11710
Merged
Merged
Conversation
…puter braille tables
LeonarddeR
previously approved these changes
Oct 1, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
This change makes sense to me. Actually I blindly copied the gesture mapping from the old driver.
michaelDCurran
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, reported by users on one of the Polish mailing lists and subsequently confirmed by Polish distributor of HIMS displays.
Summary of the issue:
Currently for HIMS braille displays F3 key is assigned to the braille points 1248. For computer braille tables however (at least for the Polish one) dots 1248 should enter number 6. For users it is impossible to write "6" from the braille keyboard in computer braille on HIMS displays.
Description of how this pull request fixes the issue:
F3 key has been remapped to Space+148. If we assume that Space+point 8 is responsible for invoking F keys this mapping is logical since dots 14 represents number 3.
Testing performed:
TBD - I'll send the build to the distributor I don't have display to test.
Known issues with pull request:
None known
Change log entry:
Section: Bug fixes
It is now possible to enter number 6 in computer braille from a braille keyboard on HIMS displays.
Changes:
For HIMS braille displays F3 has been remapped to Space + dots 148