Support the new Microsoft Quick input method for Chinese Traditional (Hong Kong) by michaelDCurran · Pull Request #11562 · nvaccess/nvda

michaelDCurran · 2020-09-04T21:58:12Z

Link to issue number:

None.

Summary of the issue:

Windows 10 introduces a newer version of the Microsoft Quick input method for Chinese Traditional (Hong Kong). these new version is all UI automation, integrated into the windowsinternal composableshell_experiences textinput_inputapp.
Users expect Automatically reading all candidates in a list, including their number, and optional short character descriptions.

Description of how this pull request fixes the issue:

Ensure that these UI automation candiate items and lists get the correct behaviour in NVDA by making use of our existing candidate behaviour NVDAObjects.

Testing performed:

In Windows 10 settings:
Add the chinese Traditional (Hong Kong) language
Add the Microsoft Quick input method as a keyboard to this language if not there already.
In Notepad or another text editor:
Switch to chinese Traditional (Hong Kong) language with alt+shift
Ensure that you are in native input mode by tapping leftShift+rightShift until you are.
Type h then i. A candidate list should appear and NVDA should read it all. Moving the up and down arrows should speak the currently selected item.
Press 5 to choose the 5th candidate. A new Associated phrases list should appear and NVDA should automatically read all candidates.
Press shift+1 to choose the first assocated phrase and NVDA should announce that these symbols are typed into the document.

Known Issues

None

change log

New features:

Added support for the new chinese Traditional Quick Input method in Windows 10.

…se Microsoft Quick input method.

…void being interupted by duplicate selection events.

michaelDCurran · 2020-09-04T22:00:52Z

@josephsl I have asked for your review on this pr as it directly touches a lot of your work in windowsinternal_composableshell_experiences_textinput_inputapp.py.
I hope this does not majorly conflict with any planned work you have -- but the Hong Kong community is quite interested in seeing this support very soon, in order that they can again enter characters with NvDA on Windows 10.

lijianwei2019 · 2020-09-04T22:52:12Z

@larry801

michaelDCurran · 2020-09-04T23:41:32Z

try build:
https://ci.appveyor.com/api/buildjobs/gaoaplkrqdd5mkte/artifacts/output%2Fnvda_snapshot_try-microsoftQuickInput-20835%2C1388e4d4.exe

larry801 · 2020-09-05T01:55:58Z

Tested the snapshot on Windows 10 19042 20207
Candidate and description can be announced.
When candidate has only one character, there is a long form description follows short form description, which is quite annoying.

Speaking [LangChangeCommand ('zh_CN'), '(你们的你)、1. 称对方，多称指一个人，有时也指称若干人：你厂。你方。 2. 泛指任何人：你死我活。', EndUtteranceCommand()]

michaelDCurran · 2020-09-05T02:09:51Z

Did this behavior happen with the old Microsoft Quick input method that NVDA supported? This pr is only to ensure that the New Quick Input Method on Windows 10 acts the same as the old one. If this issue is separate to this work, please file a separate issue. If this issue is new to this pr, please provide exact steps to reproduce, including what characters to type, and what you expect.

larry801 · 2020-09-05T02:19:03Z

Yes it happens on old Microsoft Quick input method. I will file another issue instead

larry801 · 2020-09-05T02:30:14Z

Found another issue about New Microsoft Quick

press h and y then use down and right arrow keys to navigate around candidates
nvda keeps reading blank

michaelDCurran · 2020-09-09T10:51:27Z

@larry801 are you saying that if I commit your suggestions here the new Pinyin input method will also work? or are there other changes needed as well? If so then perhaps we should leave that for another pr. But if your suggested changes are all that is needed at a minimum then I'll be happy to take them here.

larry801 · 2020-09-09T11:45:01Z

@michaelDCurran Yes the three changes are all that is needed at a minimum.

josephsl · 2020-09-09T16:27:28Z

Hi, note that this change may affect Japanese and Korean modern IME. CC @Nishomotz for confirmation. Thanks.

Co-authored-by: Larry Wang <41977369+larry801@users.noreply.github.com>

feerrenrut

Generally this looks fine to me, and I think there is plenty of time for this to get testing.

feerrenrut · 2020-09-10T13:36:06Z

+				print(f"oldText: {oldText}")
+				print(f"newText: {newText}")


I think this might need to be removed.

josephsl · 2020-09-16T03:46:11Z

Hi mick and everyone,

I must say this PR is much better than the version I have implemented in Windows 10 App Essentials, as it also supports Hanja entry in 21H1 (Korean). Once merged into master, I'll "backport" this to NVDA 2020.1 environment via WinTenApps so folks can preview this change.

Thanks.

josephsl · 2020-09-16T03:48:11Z

Follow-up: this PR may also fix #10093 provided that @nishimotz can confirm it. Thanks.

feerrenrut · 2020-10-06T14:04:11Z

If I'm not wrong, no issues have been found with this. If the debug logging is removed this should be ready to merge.

michaelDCurran added 7 commits February 12, 2020 11:57

Fully support the UIAutomation-based IME Candidate UI, used for Chine…

184d08f

…se Microsoft Quick input method.

UIA-based IME candidates: delay reading of entire pages slightly to a…

b9911e2

…void being interupted by duplicate selection events.

Fix linting issues.

016c366

Merge branch 'master' into try-microsoftQuickInput

f9c5018

Merge branch 'master' into try-microsoftQuickInput

166014b

Support Associated phrases popup for Microsoft Quick Input.

69c4402

Merge branch 'master' into microsoftQuickInput

1388e4d

michaelDCurran requested a review from josephsl September 4, 2020 21:58

michaelDCurran added this to the 2020.4 milestone Sep 4, 2020

larry801 reviewed Sep 5, 2020

View reviewed changes

Comment thread source/appModules/windowsinternal_composableshell_experiences_textinput_inputapp.py Outdated

larry801 reviewed Sep 5, 2020

View reviewed changes

Comment thread source/appModules/windowsinternal_composableshell_experiences_textinput_inputapp.py Outdated

larry801 reviewed Sep 5, 2020

View reviewed changes

Comment thread source/appModules/windowsinternal_composableshell_experiences_textinput_inputapp.py Outdated

michaelDCurran and others added 2 commits September 10, 2020 14:56

Also support Microsoft New Pinyin input method

7e56452

Co-authored-by: Larry Wang <41977369+larry801@users.noreply.github.com>

Merge branch 'master' into microsoftQuickInput

7d30993

feerrenrut previously approved these changes Sep 10, 2020

View reviewed changes

This was referenced Sep 10, 2020

Emoji panel and clipboard history: locate actual items when traversing the elements for element selected event #11485

Merged

UIA Automation Id/modern input facility: replace UIAElement.cachedAutomationId with UIAAutomationId #11483

Closed

josephsl mentioned this pull request Sep 16, 2020

Support Microsoft modern Japanese IME #10093

Closed

This comment has been minimized.

Sign in to view

michaelDCurran added 3 commits October 12, 2020 13:08

Merge branch 'master' into microsoftQuickInput

3a1d9e8

Update what's new.

0deccca

Remove debugging print statements

f664cd6

michaelDCurran dismissed feerrenrut’s stale review via f664cd6 October 12, 2020 03:12

michaelDCurran merged commit fe6a96b into master Oct 12, 2020

michaelDCurran deleted the microsoftQuickInput branch October 12, 2020 03:49

josephsl mentioned this pull request Aug 16, 2022

Windows 11 modern keyboard: support modern input method editor interface #14023

Closed

Uh oh!

Conversation

michaelDCurran commented Sep 4, 2020

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing performed:

Known Issues

change log

Uh oh!

michaelDCurran commented Sep 4, 2020

Uh oh!

lijianwei2019 commented Sep 4, 2020

Uh oh!

michaelDCurran commented Sep 4, 2020

Uh oh!

larry801 commented Sep 5, 2020

Uh oh!

michaelDCurran commented Sep 5, 2020 via email

Uh oh!

larry801 commented Sep 5, 2020

Uh oh!

larry801 commented Sep 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelDCurran commented Sep 9, 2020

Uh oh!

larry801 commented Sep 9, 2020

Uh oh!

josephsl commented Sep 9, 2020 via email • edited by feerrenrut Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

feerrenrut Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

josephsl commented Sep 16, 2020

Uh oh!

josephsl commented Sep 16, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

feerrenrut commented Oct 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

josephsl commented Sep 9, 2020 via email •

edited by feerrenrut

Loading