Map IAccessible2's checkable state to NVDA's checkable state#11377
Merged
Conversation
LeonarddeR
approved these changes
Jul 16, 2020
feerrenrut
approved these changes
Jul 17, 2020
Collaborator
|
In Chrome, this pr causes a regression for toggle buttons, which get the checkable state. Therefore, toggle buttons are reported as pressed not checked. Test case
|
This was referenced Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Accessible objects exposed via IAccessible2 may have the IAccessible2 checkable state (IA2_STATE_CHECKABLE) to state that they can be checked (E.g. a checkable list item).
This state should be mapped to NVDA's checkable state so that NVDA knows to correctly report "not checked" when the object in question does not have the checked state.
Historically, as a sort of hack, Mozilla Firefox has exposed the MSAA STATE_SYSTEM_MARQUEED to denote checkable, and NVDA has honored this.
However, since then, IAccessible2 introduced its own checkable state, and Chrome is doing the right thing by exposing this.
Description of how this pull request fixes the issue:
Simply maps IA2_STATE_CHECKABLE to NVDA's STATE_CHECKABLE.
The existing support for STATE_SYSTEM_MARQUEED specific to Mozilla Firefox is still kept as Firefox does not seem to expose the IAccessible2 checkable state yet.
Testing performed:
Tested the following testcase in both Firefox and Chrome:
And ensured that in both browsers NVDA reported not checked for the "frogs" list item.
Note that providing an aria attribute of aria-checked (set to either true or false) will expose the checkable state, and checked when it is set to true.
Known issues with pull request:
None.
Change log entry:
Bug fixes:
NVDA will now report not checked for certain controls in Google Chrome that are checkable but currently not checked.