Improve handling of elapsed/remaining time reporting in Foobar2000#11337
Merged
Conversation
* Report elapsed time if total time is not available (e.g. when playing a live stream) * Report when remaining/total time is not available instead of keeping silent
|
I'm assuming this is not talking all the time, only when you ask for it?
Brian
|
Contributor
Author
|
Sure, the functionality was already there and is triggered by a gesture
(hotkey), but now it works as expected when total time is not known.
|
feerrenrut
reviewed
Aug 10, 2020
feerrenrut
approved these changes
Sep 10, 2020
Contributor
|
Is there a corresponding translation item update for this PR? Sorry I didn't see it. |
Contributor
|
@cary-rowen it should be in the changes document "- Report elapsed time in Foobar2000 if no total time is available (e.g. when playing a live stream). (#11337)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
If Foobar2000's status bar contains elapsed time, but not the total time, reporting of elapsed time doesn't work.
This happens when Foobar2000 is playing a live stream.
Description of how this pull request fixes the issue:
Report the elapsed time, even if total time is not available. It also reports clearly if fetching total time/remaining time fails.
Testing performed:
Tested in Foobar2000 1.5.4.
Known issues with pull request:
None
Change log entry: