Browse mode with auto focus focusable elements disabled: Focus focusable ancestor at caret when forcing focus mode with NVDA+space.#11206
Conversation
…ble ancestor at caret when forcing focus mode with NVDA+space.
LeonarddeR
left a comment
There was a problem hiding this comment.
Great!
You mentioned somewhere that you made several attempts to fix this. May be you could explain in the pr description what approaches you initially tried and why they didn't work?
Originally, I was trying to do this by overriding |
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks @jcsteh the added comments help clear this up.
Link to issue number:
Addresses issue mentioned in #9511 (comment) and #11190 (comment).
Summary of the issue:
When enabling (forcing) focus mode with NVDA+space, NVDA doesn't set focus to the element under the cursor with auto focus focusable elements disabled.
Description of how this pull request fixes the issue:
Switching to focus mode with NVDA+space sets disableAutoPassThrough to True on the TreeInterceptor. Previously, this was just a variable. Now, it's a property which calls
_focusLastFocusableObject()if appropriate.Testing performed:
STR from #9511 (comment). With automatically set system focus to focusable elements disabled:
Known issues with pull request:
None.
Change log entry:
Bug fixes:
- In browse mode with Automatically set system focus to focusable elements disabled, switching to focus mode with NVDA+space now focuses the element under the caret.