-
-
Notifications
You must be signed in to change notification settings - Fork 767
Upgrade wxPython to 4.1.1 #11056
Description
Hi,
Update: originally 4.1.0, but wxPython 4.1.1 was released on November 25, 2020, hence the change of title and content. Unless requested, subsequent comments below refer to 4.1.0.
This issue serves as both a meta issue and a concrete one.
Is your feature request related to a problem? Please describe.
wxPython 4.1.0 was released on April 24, 2020, with 4.1.1 released about seven months later (November 2020). Besides internal changes to use wxWidgets 3.1.x (master branch), wxPython 4.1.1 includes the following:
- More useful notification message handling.
- Deprecated code paths.
- Python 3.8 compatibility.
- Others to be discovered.
As updating to Python 3.8 and future 3.x releases require dependency checks, wxPython 4.1.1 fulfills the first dependency check (the other major ones include SCons and Py2exe unless a much better packaging tool is found; update: Py2exe supports Python 3.8 and 3.9 as of November 2020).
Describe the solution you'd like
Upgrade to wxPython 4.1.1.
Describe alternatives you've considered
None.
Additional context
Blockers:
NVDA's own commands cannot be performed if NVDA menu is open. Also. NVDA may not appear to respond when a message dialog opens.
Past or mitigation possible:
There exists an issue in wxPython 4.1.0 where if one calls wx.Locale().Init, it changes locale and encoder seen by Python, which causes text processing to fail. The issue was traced to two areas: wxPython calling wx.App.InitLocale when an app is instantiated (can be mitigated by defining wx.App.OnPreInit), and InitLocale itself which tells wxWidgets to set the CPython locale to be in sync with wxWidgets locale.
Thanks.