Split IAccessibleHandler and Add tests for OrderedWinEventLimiter#10934
Merged
Conversation
3db6eb5 to
74cc544
Compare
This comment has been minimized.
This comment has been minimized.
74cc544 to
1fd8e80
Compare
Fix accPropServices error
IAccessibleHandler/__init__.py IAccessibleHandler/internalWinEventHandler.py
1fd8e80 to
7dedd1b
Compare
michaelDCurran
approved these changes
Apr 15, 2020
Contributor
Author
|
In order to make these changes easy to track, I won't squash merge this PR. |
feerrenrut
added a commit
that referenced
this pull request
Apr 17, 2020
7 tasks
seanbudd
pushed a commit
that referenced
this pull request
Mar 26, 2021
removes code marked as deprecated in #10934 PR #10934 refactored IAccessibleHandler into a package. This necessitated keeping some unused imports but marking them as deprecated. Also various parts of NVDA relied on the fact that IAccessibleHandler star imported all variables from IAccessible and IAccessible2 COM interfaces. Unused imports are removed from IAccessibleHandler NVDA's source has been modified to use IAccessible2 names from the COM interface rather than from IAccessibleHandler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to merge this before #10556, due to the amount of code moved preserving the history would be beneficial so I won't squash merge this.
Summary of the issue:
Much of the code for receiving and processing windows events is mixed into
IAccessibleHandler. This makes it hard to test or try different approaches. Having tests that verify the behavior is important before merging #10556Description of how this pull request fixes the issue:
In order to test this code, and implement #10556 it needed to be separated from the rest of
IAccessibleHandler.Note: Reviewing this "commit-wise" will make the changes easier to follow.
This PR makes
IAccessibleHandlerinto a package, with the majority of the code in the__init__.pyfile.Code for receiving windows events is moved to
internalWinEventHandler.pyThe
orderedWinEventLimiterclass has been moved to its own file and tests have been added (test_orderedWinEventLimiter)Testing performed:
Known issues with pull request:
Currently the biggest concern is whether this maintains backwards compatibility. Some adjustments may need to made. This has been mitigated by using tooling to check for errors in the moved files, and by careful manual inspection. If something has been missed, it will likely be very easy to fix, quite likely just re-exposing the name.
Change log entry:
Changes for developers:
- IAccessibleHandler has been converted into a package, OrderedWinEventLimiter has been extracted to a module and unit tests added (#10934)