brailleInput.handler.sendChars: allow sending Unicode characters beyond U+FFFF#10796
Merged
Conversation
See test results for failed build of commit 01f923b69e |
Collaborator
|
I wonder whether there is a cleaner way to do this than using struct. |
Member
|
Is this really just a change to an API, or is there a practical use case with a physical braille display you can describe here? |
Contributor
|
@Andre9642 Could you please respond to this commend by @michaelDCurran ? |
Contributor
Author
Assumme you have a braille table contains the following rule:
Currently, if we enter dots 2-3-4-7-8 from braille keyboard, (U+f606) is printed instead of 😆 (U+1f606). |
michaelDCurran
approved these changes
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
We currently don't properly send an Unicode characters beyond U+FFFF from the braille input.
Description of how this pull request fixes the issue:
Break UTF-32 characters into its UTF-16 surrogate pair and send them using SendInput.
Testing performed:
Tested the previous test with a try build.
Also I addded this patch to Braille Extender add-on since awhile. The add-on allows send any Unicode character via HUC/hexadecimal/decimal/octal/binary value of the character. Tested with several Unicode characters beyond U+FFFF.
Known issues with pull request:
None
Change log entry:
Section: bug fixes