FIX FOR SAPI4 SYNTHESIZERS#10792
Merged
Merged
Conversation
Added 1ms break after SAPI4 speech sequence as some synthesizers like Syntalk are completing the sequence just after last text, ignoring additional indexing
See test results for failed build of commit 5618c4c158 |
See test results for failed build of commit f4cd96abfc |
LeonarddeR
approved these changes
Feb 17, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a reasonable workaround.
Contributor
|
I can confirm, that I have tested this with synthesizers which have the indexing problems.
|
michaelDCurran
approved these changes
Feb 19, 2020
|
Hi, A similar issue exists at issue 10901. Except that has to do with SAPI5. Thanks, B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
In NVDA 2019.3 some SAPI4 synthesizers like Syntalk don't work properly. as the final index is not get by Screenreader.
As a result, when focusing some lists or explorer windows, the highlighted element is not reported. Also spelling does not work.
Description of how this pull request fixes the issue:
As the sequence is closed by some synthesizers just after reaching the last string in queue, we simply add 1ms break after all sequences sent to SAPI4 voice.
Testing performed:
The last index in speech sequence is sent to NVDA again. When focusing the desktop or using tab to navigate across elements, all items are now reported properly.
This was ested both on Windows 10 and Windows 7 and confirmed by some users from Poland.
Known issues with pull request:
None issues found.
The drawback is that spelling may prove to slow down a bit after implementing this solution.
Change log entry:
Bug fixes
SAPI4 voices should now properly report once the speak is completed