Fix double speaking label in angular checkbox#10552
Conversation
Improve names, comments and code structure.
Example from "Fix double speaking label in angular checkbox" #10552
michaelDCurran
left a comment
There was a problem hiding this comment.
I don't quite get what parentIDs does? I get that outIds stores all descendant IDs, and that if the labelledID appears in the list, then you mark it as the label coming from content.
An out of the box idea though:
Since the buffer already stores nodes by ID, rather than using your own ID lists, why not just make use of what the buffer has already. So call GetControlfieldNodeByIdentifier with the label ID, once before all the possible recursions, and then once after, at the end. If a node did not exist before, but does after, than the node is a descendant. Note that getControlFieldNodeByIdentifier is very cheep as it itself just looks up the ID in a map.
While developing this I wasn't sure if I would need to check parent ID's on the child side, and left it in for the symmetry. I see what you are suggesting, with |
During addControlFieldNode a mapping of parent->list[immediate children IDs] is built. This can then be used to get all the children for a node, or all parents for a node if necessary.
The node tree already has all the information necessary, so removing the node ID map.
|
I noticed, the aria-labelledby is not working with inner elements after 2019.3 version and it is probably related with this changes. I tested example 2 from https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute , added some button next to header, and when we are focusing on that button, main is vocalized but without h1 label. |
Link to issue number:
https://bugs.chromium.org/p/chromium/issues/detail?id=995603
Summary of the issue:
The HTML for checkboxes on https://dart-lang.github.io/angular_components/#/material_checkbox have
aria-labelledbypointing to a sub-element of the checkbox. Normally, we announce the accessible name as we descend then read the child elements. This results in double speaking the name.Description of how this pull request fixes the issue:
When rendering the virtual buffer, track the ID's of the nodes. If this node has a label, check if the ID for the label node matches any sub-node then set an attribute
labelledByContents. Then inspeech.pydon't speak the name for acontrolFieldif it has this attribute.Testing performed:
Simplified test case:
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes