Rename getBrailleTextForProperties to getPropertiesBraille#10469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Mentioned in #10371
Summary of the issue:
In #10371, getSpeechTextForProperties was renamed to getPropertiesSpeech.
Description of how this pull request fixes the issue:
Do the same for braille: getBrailleTextForProperties > getPropertiesBraille
I noticed that in the eclipse module, the position kwarg was passed to it. This is wrong, I fixed this to be positionInfo.
Testing performed:
Made sure that NVDA and braille still works.
Known issues with pull request:
NOne
Change log entry: