Add ability to reset all gestures to their factory default#10293
Conversation
|
Would it be possible not to leave behind empty gestures.ini when resetting? Not a big deal, but since by default there is no empty file created it would be nice not to have it when gestures are restored. |
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
It of course would be possible, but - please excuse my being that straight - I'm really not sure the small benefit is worth even half an hour of ensuring narrowing down all potential corner cases. |
|
It looks like some unrelated commits leaked into this branch, including changes to locale files. |
|
Don't think removing gestures.ini is really worth it.
|
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
5f91763 to
875c3ff
Compare
Indeed, seems like master has been rebased. |
|
Julien Cochuyt wrote:
Would it be possible not to leave behind empty gestures.ini when resetting? Not a big deal, but since by default there is no empty file created
it would be nice not to have it when gestures are restored.
It of course would be possible, but - please excuse my being that straight - I'm really not sure the small benefit is worth even half an hour of ensuring
narrowing down all potential corner cases.
The suggestion makes me wonder about those corner cases.
What, exactly, would be wrong with just causing the button press to delete
gestures.ini and restart NVDA? (With appropriate warning added to the existing
warning, of course, that NVDA will be restarted.)
The most likely problem is a read-only file system, and you're already having to
handle that case regardless.
|
Co-Authored-By: Luke Davis <8139760+XLTechie@users.noreply.github.com>
Co-Authored-By: Luke Davis <8139760+XLTechie@users.noreply.github.com>
With the proposed implementation, there is no need at all to restart NVDA. |
Link to issue number:
None
Summary of the issue:
As pointed out in #9688 (comment) there is currently no way in NVDA to reset all modifications a user made in the Input Gestures dialog to their factory defaults.
A user willing to do so has to manually locate and delete its
gestures.inifile.Description of how this pull request fixes the issue:
Add a button in the Input Gestures dialog to reset to factory defaults, with due prompt for confirmation and warning that this cannot be undone.
Testing performed:
Checked the user's
gestures.inifile is indeed emptied out.Checked the dialog correctly reflects the new settings, whether it was previously dirty or not.
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes