Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nvaccess/nvda
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codeofdusk/nvda
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cmduia10-fix-compareendpoints
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 6, 2019

  1. Re-implement CompareEndPoints for ConsoleUIATextInfo objects.

    @codeofdusk
    codeofdusk committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    41ba9af View commit details
    Browse the repository at this point in the history

  2. Also normalize endPoints for setEndPoint.

    @codeofdusk
    codeofdusk committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    1c4f689 View commit details
    Browse the repository at this point in the history

  3. Only normalize the source in compareEndPoints.

    @codeofdusk
    codeofdusk committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b114800 View commit details
    Browse the repository at this point in the history

  4. Fixes.

    @codeofdusk
    codeofdusk committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    134a46a View commit details
    Browse the repository at this point in the history

  5. Fixes.

    @codeofdusk
    codeofdusk committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b1b2bca View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Update docstring.

    @codeofdusk
    codeofdusk committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    68a5927 View commit details
    Browse the repository at this point in the history

  2. Bring back _get_isCollapsed.

    @codeofdusk
    codeofdusk committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    6a03087 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Review actions.

    @codeofdusk
    codeofdusk committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    5544ede View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Reef Turner <feerrenrut@users.noreply.github.com>
    @codeofdusk @feerrenrut
    codeofdusk and feerrenrut authored Aug 8, 2019
    Configuration menu
    Copy the full SHA
    6e131ad View commit details
    Browse the repository at this point in the history

  3. Review actions.

    @codeofdusk
    codeofdusk committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    41e637f View commit details
    Browse the repository at this point in the history

  4. Style.

    @codeofdusk
    codeofdusk committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    baaea09 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. _get__isCollapsed -> _isCollapsed

    @codeofdusk
    codeofdusk committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    1710df9 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Actually call _isCollapsed.

    @codeofdusk
    codeofdusk committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    5ca6241 View commit details
    Browse the repository at this point in the history
Loading