Skip to content

Commit e48645f

Browse files
authored
Merge 6e75803 into 9dc9339
2 parents 9dc9339 + 6e75803 commit e48645f

3 files changed

Lines changed: 3 additions & 11 deletions

File tree

source/NVDAObjects/window/scintilla.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,16 +313,6 @@ def _getCharacterOffsets(self, offset):
313313
tempOffset -= 1
314314
return [start, end]
315315

316-
def collapse(self, end: bool = False):
317-
"""Before collapsing to end, if no text is selected, TextInfo is expanded to line.
318-
This fixes a bug where next braille line command didn't move the cursor to the last empty line
319-
in Notepad++ documents.
320-
https://github.com/nvaccess/nvda/issues/17430
321-
"""
322-
if end and self.obj.makeTextInfo(textInfos.POSITION_SELECTION).isCollapsed:
323-
self.expand(textInfos.UNIT_LINE)
324-
super().collapse(end=end)
325-
326316

327317
# The Scintilla NVDA object, inherists the generic MSAA NVDA object
328318
class Scintilla(EditableTextWithAutoSelectDetection, Window):

source/textInfos/offsets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ def move(self, unit, direction, endPoint=None):
664664
count = 0
665665
lowLimit = 0
666666
highLimit = self._getStoryLength()
667-
if self.allowMoveToOffsetPastEnd and unit == textInfos.UNIT_CHARACTER:
667+
if self.allowMoveToOffsetPastEnd:
668668
# #2096: There is often an uncounted character at the end of the text
669669
# where the caret is placed to append text.
670670
highLimit += 1

user_docs/en/changes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ Please refer to [the developer guide](https://www.nvaccess.org/files/nvda/docume
107107
The several built-in table definitions are moved to the `__tables` module in that package. (#18194, @LeonarddeR)
108108
* Microsoft SQL Server Management Studio now uses the Visual Studio app module, as SSMS is based on Visual Studio. (#18176, @LeonarddeR)
109109
* NVDA will report Windows release revision number (for example: 10.0.26100.0) when `winVersion.getWinVer` is called and log this information at startup. (#18266, @josephsl)
110+
* Fixed behavior of `TextInfo.collapse()` - previously it was moving TextInfo to the next paragraph in some cases. (#18320, @mltony)
111+
* Fixed behavior of `OffsetTextInfo.move()` - previously it wouldn't move to the very end of the document unless moving by character. (@mltony)
110112

111113
## 2025.1.2
112114

0 commit comments

Comments
 (0)