Merge fd4ab54 into 53c8e10

XLTechie · web-flow · commit de6c3c19d352 · 2024-02-25T04:02:30.000-05:00
diff --git a/source/gui/nvdaControls.py b/source/gui/nvdaControls.py
@@ -291,7 +291,8 @@ def _setSound(self, type):
 			return
 
 	def _playSound(self):
-		winsound.MessageBeep(self._soundID)
+		if self._soundID is not None:
+			winsound.MessageBeep(self._soundID)
 
 	def __init__(self, parent, title, message, dialogType=DIALOG_TYPE_STANDARD):
 		DPIScaledDialog.__init__(self, parent, title=title)
diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
@@ -192,8 +192,10 @@ Setting ``numCells`` is still supported for single line braille displays and ``n
 - Fixed bug where deleting git-tracked files during ``scons -c`` resulted in missing UIA COM interfaces on rebuild. (#7070, #10833, @hwf1324)
 - Fix a bug where some code changes were not detected when building ``dist``, that prevented a new build from being triggered.
 Now ``dist`` always rebuilds. (#13372, @hwf1324)
+- A ``gui.nvdaControls.MessageDialog`` with default type of standard, no longer throws a None conversion exception because no sound is assigned. (#16223, @XLTechie)
 -
 
+
 === API Breaking Changes ===
 These are breaking API changes.
 Please open a GitHub issue if your Add-on has an issue with updating to the new API.
